[wp-trac] [WordPress Trac] #30366: Twenty Fifteen: make the sidebar sticky for everyone
WordPress Trac
noreply at wordpress.org
Thu Nov 20 18:12:51 UTC 2014
#30366: Twenty Fifteen: make the sidebar sticky for everyone
------------------------------+--------------------------
Reporter: celloexpressions | Owner: iandstewart
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.1
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
------------------------------+--------------------------
Comment (by honeysilvas):
'''1) We're introducing new structural HTML with #main-wrapper and moving
#content one level lower. Which makes me worry that we'll break something
else.'''
Yes, I thought about that. I'll try to think of a way where I won't have
to add a #main-wrapper. The problem is, there is no div that contains the
#content and the #footer that does not also contain the #sidebar so it's
difficult to select just the #content and the #footer as a unit.
This is more a nice-to-have rather than absolutely necessary so it's up to
you guys if it's worth the extra div.
'''2) Is that patch missing a closing tag for #main-wrapper?'''
Oops. Sorry about that. I must have missed a file when I created the
patch. I uploaded a corrected patch with the missing div.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30366#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list