[wp-trac] [WordPress Trac] #30412: get_approved_comments() behaviour change with post_id=0

[WordPress Trac]

#30412: get_approved_comments() behaviour change with post_id=0
--------------------------+--------------------
 Reporter:  dd32          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.1
Component:  Comments      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by dd32):

 > I couldn't find any instances of get_approved_comments() being called
 without a parameter, but it could be happening somewhere, so I don't see a
 reason why we should throw a notice in that case.

 Previously the parameter was required & used within the SQL, since the
 function will now return early if it's not specified, it makes sense to
 restore that behaviour.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30412#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform