[wp-trac] [WordPress Trac] #30397: Slightly confusing is_email() test name

WordPress Trac noreply at wordpress.org
Tue Nov 18 23:10:07 UTC 2014


#30397: Slightly confusing is_email() test name
--------------------------+-----------------------------
 Reporter:  dlh           |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 `is_email()` returns the string on success, not `true`, so
 `test_returns_true_if_given_a_valid_email_address` isn't strictly
 accurate.

 I bring it up only after having wanted to use the `is_email()` tests
 during a demonstration as an example of a simpler unit test in core. I
 decided against it because I thought it might confuse someone that the
 test didn't use `assertTrue()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30397>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list