[wp-trac] [WordPress Trac] #30373: wp_make_link_relative() isn't

[WordPress Trac]

#30373: wp_make_link_relative() isn't
--------------------------+------------------------------
 Reporter:  dd32          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------------
Changes (by boonebgorges):

 * keywords:  has-patch => needs-patch


Comment:

 voldemortensen - Thanks for the patch. Nitpick: can you separate the tests
 into three separate methods with more descriptive names, and put a `@group
 30373` annotation on the schemeless test, since that's the one actually
 fixed by this patch?

 It looks like you are resolving the URL parameter issue with the `^` flag
 to mark the beginning of the string - is that right? Could you write a
 test for it?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30373#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform