[wp-trac] [WordPress Trac] #30378: Empty widget areas get deactivated in the Customizer

[WordPress Trac]

#30378: Empty widget areas get deactivated in the Customizer
------------------------------+-------------------------
 Reporter:  celloexpressions  |       Owner:  ocean90
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  4.1
Component:  Customize         |     Version:  trunk
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch         |     Focuses:  javascript
------------------------------+-------------------------
Changes (by westonruter):

 * keywords:  needs-patch => has-patch
 * owner:  westonruter => ocean90
 * status:  assigned => reviewing


Comment:

 The problem seems to be the `SidebarSection.isContextuallyActive` override
 of `Section.isContextuallyActive`, which was introduced in #30235,
 specifically via commit [https://github.com/xwp/wordpress-
 develop/commit/c91db4dd0fdf03b3c62bb085db2866df9d19b362 c91db4d]. This
 method override actually was taking things too far. Now that that
 `SidebarSection`'s active state is getting sent from the Preview, we can
 just rely on it to show/hide the section. We don't want to hide a section
 if all of the widgets in a section are removed or if they are all inactive
 (e.g. hidden via Jetpack Widget Visibility). So the method override I
 added was just plain wrong, I believe.

 In [attachment:30378.diff] I remove this method override.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30378#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform