[wp-trac] [WordPress Trac] #29699: add_theme_support( 'screen-reader-text' );

WordPress Trac noreply at wordpress.org
Tue Nov 18 05:43:40 UTC 2014


#29699: add_theme_support( 'screen-reader-text' );
-------------------------+------------------------------
 Reporter:  GaryJ        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Themes       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  accessibility
-------------------------+------------------------------

Comment (by obenland):

 Maybe I should have been more verbose in
 [https://core.trac.wordpress.org/ticket/29699#comment:13 my previous
 comment].

 The search form uses `.screen-reader-text` since r11312. No theme should
 need to register support for this class, as they should already support
 it!

 > The only sensible way for a theme to opt in, is to add theme support.
 This is not how built-in classes work. Themes can't pick and choose
 classes that they support. Nor should they be able to.

 > The Genesis Framework search form, by default doesn't have a <label>.
 I'm sorry to hear that, but that doesn't mean that core should provide a
 solution for Genesis' shortcoming. We can't be accountable for the custom
 overrides that we allow developers to do.

 Also, using theme support to denote support for a specific class feels
 like using a sledgehammer to crack a nut.
 If there are themes that don't have `.screen-reader-text` defined, it's an
 opportunity to educate their authors about it. It is not something for
 core to fix.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29699#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list