[wp-trac] [WordPress Trac] #30358: Twenty Fifteen: Improve site description handling within the Customizer.

WordPress Trac noreply at wordpress.org
Mon Nov 17 02:37:05 UTC 2014


#30358: Twenty Fifteen: Improve site description handling within the Customizer.
-------------------------------+-----------------------------
 Reporter:  philiparthurmoore  |      Owner:
     Type:  defect (bug)       |     Status:  new
 Priority:  normal             |  Milestone:  Awaiting Review
Component:  Bundled Theme      |    Version:  trunk
 Severity:  normal             |   Keywords:
  Focuses:                     |
-------------------------------+-----------------------------
 Right now, this is the code that’s used to output site descriptions in
 Twenty Fifteen:

 {{{
 <?php
                                         $description = get_bloginfo(
 'description', 'display' );
                                         if ( ! empty( $description ) ) :
 ?>
                                                 <p class="site-
 description"><?php echo esc_html( $description ); ?></p>
                                         <?php endif;
 }}}

 That’s nice because junky markup isn’t added into the front-end when a
 blog description is empty. This is problematic, though, inside of the
 Customizer when using `postMessage`.

 1. Make your site description blank.
 2. Reload your Customizer.
 3. Try to add a description into the site.
 4. Nothing is reflected inside of the customizer.

 Because no markup is present for `postMessage` when a site description is
 empty we either need to a) revert `get_setting( 'blogdescription'
 )->transport` to `refresh` by removing that line altogether (since refresh
 is the default) or b) add some logic into `header.php` that outputs markup
 when we’re inside of the customizer and a site title is empty.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30358>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list