[wp-trac] [WordPress Trac] #29610: FTPext Filesystem class can't detect isWritable, isReadable correctly

[WordPress Trac]

#29610: FTPext Filesystem class can't detect isWritable, isReadable correctly
----------------------------+------------------------------
 Reporter:  programmin      |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Filesystem API  |     Version:  2.5
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------------------

Comment (by dd32):

 > Why not, can you please clarify?

 Quite simply because we assume that FTP access has the ability to modify
 the files. Short of attempting to write to each file, there isn't an easy
 way to cover every system.
 If a file is chmod to 400, we'll alter it to 644 and attempt again, if
 it's 777 and a linux/windows ACL prevents write, we can't "see" that ACL
 or write to the file.

 So for the vast majority of sites, we can simply assume that FTP has write
 access to the system.
 If a system has mixed permissions on files or various ACL's on specific
 locations, then it's a system we don't fully support, WordPress does it's
 best, but it may fail, this is usually only seen when someone leaves some
 files owned by `root`.

 > also does not allow removal of broken plugin-directory when installing
 the plugin again
 This is for technical & legacy reasons, preventing overwriting of a
 different plugin, and a few other obscure reasons I can't quite remember.
 This scenario is basically one that should never be hit on any server
 where everything is working correctly, call it a failsafe, manual
 interaction is often required to determine what (if anything) caused it in
 the first place.

 I'm fairly certain there's another ticket somewhere to alter that check to
 ignore the flag if the directory is empty.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29610#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform