[wp-trac] [WordPress Trac] #29988: Twenty Fifteen: Use JS/postMessage to update the color scheme instead of triggering a page refresh

WordPress Trac noreply at wordpress.org
Thu Nov 6 18:19:48 UTC 2014


#29988: Twenty Fifteen: Use JS/postMessage to update the color scheme instead of
triggering a page refresh
------------------------------------+-----------------------------
 Reporter:  avryl                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Bundled Theme           |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  javascript
------------------------------------+-----------------------------

Comment (by westonruter):

 OK, I took a closer look. I think I missed that critical piece of the
 `color_scheme_css` theme_mod setting being added and populated via JS. In
 that case, there is no need for PHP to render as long as the
 `color_scheme`, `background_color`, and `header_background_color`, and
 other settings are only ever modified via the Customizer. Nice one,
 bradyvercher!

 One caution: if the user were able to change one of those settings that
 comprise the `color_scheme_css` setting outside the Customizer, for
 instance in the Appearance > Background admin page, then the JS-computed
 `color_scheme_css` would no longer be valid, right? We can help prevent
 that if #25569 and #25571 can land.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29988#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list