[wp-trac] [WordPress Trac] #30256: Create and exclude an area for ms-files.php specific unit tests

WordPress Trac noreply at wordpress.org
Thu Nov 6 06:47:00 UTC 2014


#30256: Create and exclude an area for ms-files.php specific unit tests
------------------------------+------------------------
 Reporter:  jeremyfelt        |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.1
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  multisite
------------------------------+------------------------

Comment (by jeremyfelt):

 After moving the `ms_files_rewriting` flag out of the main multisite
 tests, another test started failing because one of the images was
 incrementing its filename in the uploads directory due to a conflict. My
 guess is that the ms-files flag was causing a change in the upload
 directory which helped avoid a conflict.

 I went down the rabbit hole for a minute in
 [https://core.trac.wordpress.org/attachment/ticket/30256/30256.2.diff
 30256.2.diff], which set a prefix on uploaded files in the failing test,
 but I think the problem more likely lies in us not using
 `remove_added_uploads()` on every `tearDown()` that should have it.

 This will be tomorrow's rabbit hole.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30256#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list