[wp-trac] [WordPress Trac] #29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts

[WordPress Trac]

#29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts
------------------------------------------------------+--------------------
 Reporter:  MrBobDobolina                             |       Owner:
     Type:  defect (bug)                              |      Status:  new
 Priority:  highest omg bbq                           |   Milestone:  4.0.1
Component:  Formatting                                |     Version:  4.0
 Severity:  blocker                                   |  Resolution:
 Keywords:  wptexturize has-patch commit fixed-major  |     Focuses:
------------------------------------------------------+--------------------

Comment (by MikeNGarrett):

 I definitely agree with the first approach, although I would rather go
 with the second. I'm afraid the second would alienate a lot of content
 managers and plugin authors.

 I ran through phpunit tests put forward in
 [https://core.trac.wordpress.org/attachment/ticket/29557/29557-idea-3.3.diff
 29557-idea-3.3] and can comfirm they passed. I also did my own testing
 with one of the main shortcode gallery plugins,
 [https://wordpress.org/plugins/shortcodes-ultimate/ Shortcodes Ultimate].
 The only feature that didn't work with the patch is their own version of
 allowing shortcodes to be attributes of other shortcodes, for example
 {{{ [su_button url="{su_spoiler title='Spoiler title'}"] Button
 [/su_button] }}}

 The output in this case is broken, which is to be expected. The problem is
 that it's outputting invalid code to the front-end, so anyone that's
 currently using this format would have broken content.


 On the other hand, shortcode nesting still worked, for example
 {{{
 [su_accordion]
 [_su_spoiler title="Spoiler title"] Spoiler content [_/su_spoiler]
 [_su_spoiler title="Spoiler title"] Spoiler content [_/su_spoiler]
 [_su_spoiler title="Spoiler title"] Spoiler content [_/su_spoiler]
 [/su_accordion]
 }}}
 All other examples I tested worked perfectly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29557#comment:112>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform