[wp-trac] [WordPress Trac] #30218: _.isUndefined( _wpRevisionsSettings ); should be _.isUndefined( window._wpRevisionsSettings );

WordPress Trac noreply at wordpress.org
Sat Nov 1 00:19:20 UTC 2014


#30218: _.isUndefined( _wpRevisionsSettings ); should be _.isUndefined(
window._wpRevisionsSettings );
------------------------------+-----------------------------
 Reporter:  ericlewis         |       Owner:  wonderboymusic
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.1
Component:  Revisions         |     Version:  3.6
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  javascript
------------------------------+-----------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"30130"]:
 {{{
 #!CommitTicketReference repository="" revision="30130"
 Set `revision.settings` via short-circuit check for `window` property:
 `window._wpRevisionsSettings || {}`

 Props ericlewis.
 Fixes #30218.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30218#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list