[wp-trac] [WordPress Trac] #27881: Compatibility with Hack

[WordPress Trac]

#27881: Compatibility with Hack
----------------------------+--------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+--------------------

Comment (by wonderboymusic):

 Here are some issues to look at, might not all be valid, but is the
 remaining actionable output from `hackificator`:
 {{{
 wp-admin/includes/class-wp-filesystem-base.php:357:19,26: The method
 getchmod is undefined in an object of type WP_Filesystem_Base ... wp-
 admin/includes/class-wp-filesystem-base.php:14:7,24: Check this out

 wp-admin/includes/class-wp-filesystem-direct.php:24:18,28: You are
 extending a class that needs to be initialized
  Make sure you call parent::__construct.

 wp-admin/includes/class-wp-filesystem-ftpsockets.php:22:18,28: You are
 extending a class that needs to be initialized
  Make sure you call parent::__construct.

 wp-admin/includes/class-wp-filesystem-ssh2.php:44:18,28: You are extending
 a class that needs to be initialized
  Make sure you call parent::__construct.

 wp-admin/includes/class-wp-upgrader-skins.php:28:31,31: Don't use
 references!

 wp-admin/includes/class-wp-upgrader-skins.php:702:11,17: The member
 options is undefined in an object of type Automatic_Upgrader_Skin
    wp-admin/includes/class-wp-upgrader-skins.php:697:7,29: Check this out

 wp-admin/includes/class-wp-users-list-table.php:388:5,8: Expected modifier

 wp-admin/includes/deprecated.php:341:2,4: Expected modifier

 wp-admin/includes/list-table.php:90:18,38: This is a dangerous method
 name, if you want to define a constructor, use __construct

 wp-admin/includes/revision.php:176:35,47: The variable $restore_link is
 defined
    wp-admin/includes/revision.php:135:4,16: But in a different scope)

 wp-admin/includes/template.php:38:29,29: Don't use references!

 wp-admin/options.php:235:12,12: Expected attribute value

 wp-admin/plugin-editor.php:235:224,224: Expected ul

 wp-admin/update-core.php:613:20,20: Expected attribute value

 wp-includes/bookmark-template.php:246:21,25: The variable $cats is defined
   wp-includes/bookmark-template.php:231:3,7: But in a different scope

 wp-includes/capabilities.php:307:2,4: Expected modifier

 wp-includes/category.php:344:28,28: Don't use references!

 wp-includes/class-oembed.php:181:66,71: Undefined variable: $links

 wp-includes/class-wp-customize-setting.php:392:45,45: Don't use
 references!

 wp-includes/class-wp-image-editor.php:277:22,34: The method get_extension
 is undefined in an object of type WP_Image_Editor
     wp-includes/class-wp-image-editor.php:14:16,30: Check this out

 wp-includes/class-wp-walker.php:100:29,29: Don't use references!

 wp-includes/class-wp-walker.php:333:12,21: The variable $total_top is
 defined
   wp-includes/class-wp-walker.php:327:4,13: But in a different scope

 wp-includes/class-wp-xmlrpc-server.php:265:26,26: Don't use references!

 wp-includes/class.wp-dependencies.php:122:10,42: Too many arguments

 wp-includes/class.wp-scripts.php:172:15,20: The variable $after is defined
   wp-includes/class.wp-scripts.php:159:4,9: But in a different scope

 wp-includes/cron.php:327:10,10: Yeah...we're not going to support
 continue/break N. It makes static analysis tricky and it's not really
 essential)

 wp-includes/date.php:108:2,9: Expected modifier

 wp-includes/default-widgets.php:16:2,9: Expected modifier

 wp-includes/class.wp-styles.php:87:10,146: Too many arguments
   wp-includes/plugin.php:156:10,22: Definition is here

 wp-includes/query.php:3425:2,9: Expected modifier

 wp-includes/revision.php:289:31,31: Don't use references!

 wp-includes/rewrite.php:428:2,4: Expected modifier

 wp-includes/script-loader.php:50:30,30: Don't use references!

 wp-includes/user.php:452:2,4: Expected modifier

 wp/wp-includes/widgets.php:26:2,4: Expected modifier

 wp-includes/wp-db.php:64:2,4: Expected modifier

 wp-includes/wp-diff.php:34:2,4: Expected modifier
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27881#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform