[wp-trac] [WordPress Trac] #28172: edit_post() should call {un}stick_post() before calling wp_update_post()

[WordPress Trac]

#28172: edit_post() should call {un}stick_post() before calling wp_update_post()
-------------------------------+------------------------------
 Reporter:  pbiron             |       Owner:
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Posts, Post Types  |     Version:  trunk
 Severity:  normal             |  Resolution:
 Keywords:                     |     Focuses:
-------------------------------+------------------------------

Comment (by pbiron):

 a little more investigation suggests that it will also be necessary to
 make a similar change in
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 xmlrpc-server.php#4900].

 In particular, `wp_xmlrpc_server::mw_editPost()` calls `wp_insert_post()`
 before calling `{un}stick_post()`.

 `wp_xmlrcp_server::_insert_post()` and `wp_xmlrpc_server::mw_newPost()`,
 however, call them in the "correct" order and won't require a change.

 I don't even know what the `wp_xmlrpc_server` class does so I can't test
 that my proposed fix works here as well.  I'd appreciate it someone who
 actively uses `wp_xmlrcp_server` could test that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28172#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform