[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28332"]:
 {{{
 #!CommitTicketReference repository="" revision="28332"
 In `get_pages()`, `$cache` does not need to be reset to an empty array.
 `update_post_cache( $pages )` takes care of priming.

 In `set_post_thumbnail()`, (accidental) assignment is unnecessary for
 `$thumbnail_html` as it is not used.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform