[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28323"]:
 {{{
 #!CommitTicketReference repository="" revision="28323"
 In `wp-includes/comment-template.php`, remove dead code:

 * In `get_comment_reply_link()`, `$link` is set twice before it is used.
 * In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless
 placed before `default:`.
 * In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless
 placed before `default:`.
 * In `comment_form()`, `$id` is conditionally set and never used.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform