[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28292"]:
 {{{
 #!CommitTicketReference repository="" revision="28292"
 In `ajax-actions.php`, remove dead code:

 * In `wp_ajax_add_tag()`, `$post_type` is set and never used.
 * In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks
 for the existence of `$_POST['hidden']` the first time. The two lines can
 be combined and work together.
 * In `wp_ajax_inline_save()`, `$mode` is set and never used.
 * In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover
 cruft, neither variable is used. `$wpdb` does not need to be imported, it
 is never used.
 * In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never
 used.
 * In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
 * In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never
 used.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform