[wp-trac] [WordPress Trac] #28147: No ratings string never used?
WordPress Trac
noreply at wordpress.org
Tue May 6 12:12:18 UTC 2014
#28147: No ratings string never used?
--------------------------+-----------------------------
Reporter: pavelevap | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: I18N | Version: 3.9
Severity: normal | Keywords:
Focuses: |
--------------------------+-----------------------------
String "No ratings." is probably never used.
https://core.trac.wordpress.org/browser/tags/3.9/src/wp-admin/theme-
install.php#L236
There is following condition:
{{{
<# if ( data.num_ratings ) { #>
}}}
But data.num_ratings is the whole string "(based on %s rating)" and never
empty or null. When there is no rating, data.num_ratings will be "(based
on 0 rating)". And this is not ideal...
I am not sure which variable contains real number of ratings to patch this
issue.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28147>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list