[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28268"]:
 {{{
 #!CommitTicketReference repository="" revision="28268"
 Dead code in `wp-admin/includes/file.php`:
 * In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets
 conditionally reset... and then is never used.
 * In `request_filesystem_credentials()`, `$password` is initialized as an
 empty string. The variable is never used.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform