[wp-trac] [WordPress Trac] #28124: Use a time constant instead of a number in get_theme_feature_list()

WordPress Trac noreply at wordpress.org
Mon May 5 05:43:41 UTC 2014


#28124: Use a time constant instead of a number in get_theme_feature_list()
--------------------------------------+------------------
 Reporter:  SergeyBiryukov            |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.0
Component:  Themes                    |     Version:  3.5
 Severity:  trivial                   |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------
Changes (by GaVrA):

 * keywords:  needs-patch good-first-bug => good-first-bug has-patch


Comment:

 Second patch, day after contributors day at WordCamp Switzerland! :)

 So the [attachment:28124.diff] takes care of what you wanted. :)

 I did some search inside {{{wp-admin}}} and found following things:

 File {{{wp-admin/load-styles.php}}}

 {{{
 #!php
 $expires_offset = 31536000; // 1 year
 }}}

 File {{{wp-admin/load-scripts.php}}}

 {{{
 #!php
 $expires_offset = 31536000; // 1 year
 }}}

 File {{{wp-admin/includes/class-wp-upgrader.php}}}

 {{{
 #!php
 // schedule a cleanup for 2 hours from now in case of failed install
 wp_schedule_single_event( time() + 7200, 'upgrader_scheduled_cleanup',
 array( $this->id ) );
 }}}

 Should that be updated via this ticket or a new one?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28124#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list