[wp-trac] [WordPress Trac] #28121: Theme Feature Filter problem with Warnings

[WordPress Trac]

#28121: Theme Feature Filter problem with Warnings
-----------------------------+--------------------
 Reporter:  pavelevap        |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  3.9.2
Component:  Themes           |     Version:  trunk
 Severity:  critical         |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+--------------------
Changes (by SergeyBiryukov):

 * priority:  normal => highest omg bbq
 * severity:  normal => critical
 * milestone:  Awaiting Review => 3.9.2


Comment:

 Confirmed.

 See the relevant block in `get_theme_featured_list()`:
 [source:tags/3.9/src/wp-admin/includes/theme.php#L261].

 `$feature_items` used to be a simlpe array, and now it contains a nested
 array:
 {{{
 Array(
         [name] => Colors
         [items] => Array(
                 [black] => black
                 [blue] => blue
                 [brown] => brown
                 [gray] => gray
                 [green] => green
                 [orange] => orange
                 [pink] => pink
                 [purple] => purple
                 [red] => red
                 [silver] => silver
                 [tan] => tan
                 [white] => white
                 [yellow] => yellow
                 [dark] => dark
                 [light] => light
         )
 )
 }}}

 [attachment:28121.patch] fixes this, but it's also broken in 3.8.3 and all
 previous versions, so this looks like an accidental change on the
 WordPress.org API side that should be reverted.

 Moving to 3.9.2 for tracking.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28121#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform