[wp-trac] [WordPress Trac] #21785: Add header image uploads with cropping to the customizer
WordPress Trac
noreply at wordpress.org
Mon Mar 31 16:41:49 UTC 2014
#21785: Add header image uploads with cropping to the customizer
----------------------------+-----------------------------------------
Reporter: nacin | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.9
Component: Appearance | Version: 3.4
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, administration
----------------------------+-----------------------------------------
Comment (by ehg):
Replying to [comment:55 ocean90]:
> Replying to [comment:54 nacin]:
> > * [attachment:21785-mm-crop-error-button.diff] — Nice! Chances are a
crop isn't a transient failure, so I'm not sure how much a retry will
help, but we have very little recourse here. Asking others to weigh in to
see if anyone else can think of an existing paradigm we should otherwise
copy.
>
> I think it should be more like these errors:
https://cloudup.com/c4LTYurtj7z
> The image should be replaced by the error message with a link to retry.
The Crop button should be disabled when an error exists.
attachment:21785-mm-crop-error-overlay.diff overlays the error message on
top of the image. I avoided a 'retry' link, to keep the patch minimal.
It:
* Uses a template for Cropper view, rather having it as an img element, so
we can add more elements to it in a clean way.
* Re-uses media.view.UploaderStatusError to overlay cropping errors onto
the image
* Fixes an issue where imgAreaSelect was referencing the wrong parent
element - which lead to weirdness with z-indexes in the crop-content
template.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/21785#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list