[wp-trac] [WordPress Trac] #26778: Visual editor not showing wysywig editor and white text on white background

[WordPress Trac]

#26778: Visual editor not showing wysywig editor and white text on white background
--------------------------+----------------------
 Reporter:  marcreck      |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  3.9
Component:  TinyMCE       |     Version:  3.8
 Severity:  normal        |  Resolution:  invalid
 Keywords:                |     Focuses:
--------------------------+----------------------

Comment (by tollmanz):

 Replying to [comment:29 toscho]:
 > I know it isn’t valid. But it breaks backwards-compatibility, and it
 doesn’t even throw a JavaScript error to explain it. Just leaving people
 alone with such a change is not a good solution.

 I would argue that this is not a regression. In
 [https://github.com/WordPress/WordPress/blob/3.8.1/wp-includes/general-
 template.php#L1878 3.8.1], the docblock states that the {{{$editor_id}}}
 value can only be {{{/[a-z]+/}}}. Before I realized this in 3.8, I used a
 bracket in {{{$editor_id}}} in an instance of {{{wp_editor}}} (not
 realizing that I could set the {{{textarea_name}}} value independently).
 This broke the link button for me because the {{{$editor_id}}} value is
 used as part of a [https://github.com/WordPress/WordPress/blob/3.8.1/wp-
 includes/js/wplink.js#L66 jQuery selector], which does not allow brackets.
 I had to override this function for it to work.

 WordPress 3.9 broke this further and I experienced the problems that you
 did; however, because WordPress' docs clearly advised that brackets are
 not allowed and because the editor did not work fully with brackets in the
 previous version, I do not see this as a regression given that the updated
 code is acting on assumptions that are articulated for appropriate use of
 the API. My solution was to update my code as it is clear that there is a
 good reason why brackets are not allowed for the {{{$editor_id}}} value.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26778#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform