[wp-trac] [WordPress Trac] #27574: ID3 data should be editable

[WordPress Trac]

#27574: ID3 data should be editable
----------------------------+------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Media           |     Version:  3.6
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+------------------

Comment (by nacin):

 Replying to [comment:2 helen]:
 > Is there anything we can map to existing post fields? Band and length
 fields also seem unnecessary by default. Also,
 `wp_get_relevant_id3_keys()` is screaming for a filter.

 Agreed.

 Further:

  * Rather than `foreach ( array_flip( wp_get_relevant_id3_keys() ) as $key
 )` I'd do `foreach ( wp_get_relevant_id3_keys() as $key => $label )` and
 just not use $label.

  * id3data_meta_box() could use a better name, at the very least something
 like attachment_id3_data_meta_box().

  * Since we have an opportunity to give a core meta box a non-horrible
 name (which they almost universally have), maybe we can change
 "id3datadiv" to something like "attachment-id3"

  * Should we expect ID3 data to have HTML in it? Or block HTML? Or worse,
 unsafe HTML? Let's go with wp_kses_data() if we expect HTML, that avoids
 block-level and unsafe stuff. Note also that wp_filter_post_kses() works
 on slashed data (and returns slashed data), so the right function would
 have been wp_kses_post(). Yeah, they're all terrible names too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27574#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform