[wp-trac] [WordPress Trac] #23587: url_to_postid() needs to use # or @ for preg_match start/end character

[WordPress Trac]

#23587: url_to_postid() needs to use # or @ for preg_match start/end character
------------------------------+---------------------
 Reporter:  coreygilmore      |       Owner:  nacin
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  3.9
Component:  Rewrite Rules     |     Version:  1.5.2
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+---------------------

Comment (by Denis-de-Bernardy):

 Replying to [comment:14 nacin]:
 > What part of that IRC conversation did you not read? Oh, right, the part
 where I said "#s don't work cause of #12271. I forgot about that. So #
 seems to be fine, then."

 That came later in the conversation and, incidentally, had been
 highlighted already by yours truly in this very ticket:

 https://core.trac.wordpress.org/ticket/23587#comment:8

 > I'm juggling a few hundred tickets a week

 So do I, fwiw.

 > I don't remember every little detail about each of them.

 Can't blame you for that: things would be a lot simpler if the WP bug
 tracker had less bugs open each time WP ships.

 > Attitude matters, Denis.

 So does reading feedback to objections you raise in tickets or IRC when
 someone is helpfully researching a ticket in order to provide you with the
 needed context to make the right decision asap.

 Or addressing obvious bugs with obvious fixes proactively, for that
 matter.

 (See #27550 for another example of such. Create a post with a bunch of
 slashes in its title, then trash it or untrash it to see for yourself. The
 fix is utterly obvious, too: `wp_slash()` the data before calling
 `wp_update_post()`.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23587#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform