[wp-trac] [WordPress Trac] #25834: WP_Date_Query not allowed values possible
WordPress Trac
noreply at wordpress.org
Wed Mar 26 21:37:07 UTC 2014
#25834: WP_Date_Query not allowed values possible
------------------------------------------+------------------
Reporter: ChriCo | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.9
Component: Query | Version: 3.7
Severity: normal | Resolution:
Keywords: needs-patch needs-unit-tests | Focuses:
------------------------------------------+------------------
Comment (by Viper007Bond):
Okay, then I can see triggering a notice if a value is wrong. That would
indeed be helpful to developers.
I have some issues with the actual patch though. For example
`validate_date_values()` shouldn't run unless `WP_DEBUG` is enabled.
There's no reason to validate the values in a production environment,
especially if no notice is going to be triggered. There's also some
various coding standards issues and stuff like that.
I'll throw together an updated patch.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25834#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list