[wp-trac] [WordPress Trac] #21785: Add header image uploads with cropping to the customizer

[WordPress Trac]

#21785: Add header image uploads with cropping to the customizer
----------------------------+-----------------------------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Appearance      |     Version:  3.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, administration
----------------------------+-----------------------------------------

Comment (by ehg):

 Replying to [comment:41 nacin]:

 > > We’d like to make the case for a better, broader solution to error
 handling that would go beyond this ticket: adding a Customizer error
 handler that would display error messages by binding to customize(‘error’)
 events - see  https://cloudup.com/ihRG2lmDTkC . We could also use the
 proposed error handling in the Customizer to show ‘crop failed’ events
 from the Media Manager.
 >
 > Yeah, I think that makes sense. For the moment, we just need to make
 sure that if/when an XHR fails, things don't go completely haywire. (No JS
 failures, etc.)

 Apart from the Media Manager's "Cropping..." button being stuck on an
 error, the two other XHR requests (header_add/header_remove) will just
 silently fail on errors.

 attachment:21785-mm-crop-error-button.diff (depends on attachment:21785
 -doCrop-move.2.diff) changes the "Crop" button to "Error? Retry" on an
 error - pic: https://cloudup.com/cb4uy8jfehO

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21785#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform