[wp-trac] [WordPress Trac] #27292: HTML5 Captions: Apply the filter img_caption_shortcode_width

[WordPress Trac]

#27292: HTML5 Captions: Apply the filter img_caption_shortcode_width
-------------------------+----------------------
 Reporter:  jond3r       |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Media        |     Version:  trunk
 Severity:  normal       |  Resolution:  invalid
 Keywords:  has-patch    |     Focuses:
-------------------------+----------------------

Comment (by jond3r):

 Replying to [comment:8 obenland]:
 > Since HTML5 captions don't have the added 10px, it would break backwards
 compatibility if we applied the filter there.

 Sorry, but I have to defend myself. I think your argument is invalid. If
 HTML5 caption support is not added, the filter will still get width +
 10px, so backwards compatibility i preserved. On the other hand, if HTML5
 caption support is added, "no strings are attached", so a changed input
 value to the filter must be accepted. The filter documentation can be
 updated to reflect this.

 The proposed enhancement here is not breaking backwards compatibility any
 more than the recently committed patch [27668]. I think this enhancement
 proposal is still valid.

 (As a personal side note, it was unfortunate that I managed to file this
 ticket just a few hours before your proposal in 26642. It is not my
 intention to be a troublemaker, I'm just trying to defend myself and a
 sound opinion. I'm afraid I'm at risk of being banned from wordpress.org
 for this. Hopefully I'm not.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27292#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform