[wp-trac] [WordPress Trac] #27003: Introduce wp_get_network() and begin cleanup of multisite load
WordPress Trac
noreply at wordpress.org
Mon Mar 24 01:28:50 UTC 2014
#27003: Introduce wp_get_network() and begin cleanup of multisite load
----------------------------+------------------------
Reporter: jeremyfelt | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.9
Component: Bootstrap/Load | Version: trunk
Severity: normal | Resolution:
Keywords: needs-testing | Focuses: multisite
----------------------------+------------------------
Comment (by nacin):
I'm closing this out. '''New tickets for any other issues.''' Great work,
jeremyfelt, I'm loving this. :-)
Replying to [comment:49 jeremyfelt]:
> * In `get_network_by_path()`, we use `wp_get_network()` to retrieve the
same object we just retrieved. It may be worth dropping that additional
call for now until we know it's needed.
I figure that wp_get_network() will eventually start returning a proper
object, so I wanted to go ahead with this abstraction now. Also,
originally, there was some decoration that occurred in wp_get_network().
It doesn't matter for the moment. That said, emphasizing that a DB row
should be passed through to wp_get_network() sets a good standard for
others to do so, which means the migration to a proper object might be
smoother.
> * Actions for `found_site_by_path` and `found_network_by_path` when
sites and networks are being returned by their respective functions could
be useful as a way for sunrise to hook in and set custom caching (or other
functionality) for repeat requests.
Seems OK; I imagine you're referring to then leveraging that information
in a pre_* hook. Let's spin off a separate ticket for this, though.
> * Thinking through a filter for setting the cookie domain to allow
sunrise to hook in there as well in advance of any future cookie handling
that we do.
Since cookie handling is a separate can of worms, let's also make that a
separate ticket.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27003#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list