[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

WordPress Trac noreply at wordpress.org
Sat Mar 22 13:56:50 UTC 2014


#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  Future
Component:  Plugins                              |  Release
 Severity:  normal                               |     Version:  trunk
 Keywords:  has-patch needs-testing dev-         |  Resolution:
  feedback has-unit-tests                        |     Focuses:
-------------------------------------------------+-------------------------

Comment (by jbrinley):

 Replying to [comment:52 Denis-de-Bernardy]:
 > Likely -1 here. Won't 17814.4 break plugins that look into the
 $wp_filter global in an effort to remove observers added by plugins that
 are anonymous? Plugins and such that change $wp_filter directly, such as
 what occurs in some of the unit tests?

 @Denis-de-Bernardy, would your concerns be assuaged if `WP_Hook`
 implemented `ArrayAccess`, `IteratorAggregate`, and `Countable` (basically
 extending `ArrayObject`)?

 In my opinion, it's unnecessary bloat for the benefit of a few edge cases
 where plugins take advantage of undocumented WP internals. But, my opinion
 aside, the solution is relatively straight forward. I'd appreciate your
 feedback, and maybe even a unit test or two specifying exactly what you
 expect from it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list