[wp-trac] [WordPress Trac] #25663: Upgrade Plupload to 2.0

[WordPress Trac]

#25663: Upgrade Plupload to 2.0
-------------------------------------+------------------
 Reporter:  azaozz                   |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  3.9
Component:  External Libraries       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:
-------------------------------------+------------------

Comment (by azaozz):

 Replying to [comment:11 kovshenin]:
 > To work around this we can partially revert r18674 where we stopped
 passing our authentication cookies to post_params.

 Not sure this is a good idea. Our cookies are HTTP only, exposing them in
 the HTML is not good. That was one of the reasons for switching to
 Plupload too.

 Emailed Davit (the lead developer of Plupload) and he traced the problem
 to the removal of the `urlstream_upload` option from 2.0. This was setting
 alternate mode in the flash runtime which ensures sending of cookies but
 requires the whole file to be loaded in memory. This also prevents
 uploading of big files with flash.

 The same can be done in 2.0 by using
 {{{
 required_features: {
      send_binary_string: true
 }
 }}}

 Tested further and it seems flash always sends cookies in IE, regardless
 of the above setting. 25663.3.diff is based on that. It checks whether
 flash will be used, then sets the above option in non IE browsers. As by
 default we use flash only for old IE, this seems the best alternative.

 More testing especially in IE < 10 very welcome :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25663#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform