[wp-trac] [WordPress Trac] #27462: Twenty Thirteen and Fourteen: Add Audio, Video, and Gallery Styles to editor styles
WordPress Trac
noreply at wordpress.org
Thu Mar 20 01:24:52 UTC 2014
#27462: Twenty Thirteen and Fourteen: Add Audio, Video, and Gallery Styles to
editor styles
-------------------------------------------------+--------------------
Reporter: celloexpressions | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.9
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch has-patch needs-testing | Focuses: ui
-------------------------------------------------+--------------------
Changes (by celloexpressions):
* keywords: needs-patch => needs-patch has-patch needs-testing
Comment:
[attachment:27462.fourteen.diff] covers all of the views for Twenty
Fourteen. It looks great generally, and matches the front-end (other than
the default styling when the gallery is selected). The captions-on-hover
even work.
Because of the negative margins on the gallery div, it's a bit hacky to
keep everything perfectly aligned. Once there are more than 3 columns (or
the images are bigger than 150px, or the viewport is less than ~500px,
which I didn't account for), there is no solution other than to have the
images overflow the "selected" border. However, I think that this behavior
is acceptable, as long as the gallery is centered on the border.
This'll need extensive testing, and getting this committed is probably the
best way to encourage that. I'll do the Twenty Thirteen styles later, but
they're almost identical to Fourteen and should have exactly the same
issues.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27462#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list