[wp-trac] [WordPress Trac] #26959: Incorporate preview of inserted galleries in the visual editor using a new version of the wpview tinymce plugin

[WordPress Trac]

#26959: Incorporate preview of inserted galleries in the visual editor using a new
version of the wpview tinymce plugin
----------------------------+-----------------------------
 Reporter:  gcorne          |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Editor          |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  ui, javascript
----------------------------+-----------------------------

Comment (by adamsilverstein):

 [attachment:26959-ensure-thumb-in-template.diff] - alternate method to
 ensure thumbnails work - puts the logic in the template, use full size
 image when thumbnail missing. I think its a little cleaner this way.


 Replying to [comment:22 adamsilverstein]:
 > This might deserve a separate ticket? I created a fix in
 [attachment:26959-ensure-thumbnail.diff] that copies over the full size
 when the thumbnail size is missing.
 >
 > you can reproduce the issue by adding a small image to the gallery
 (smaller than the thumbnail size) - the preview breaks and the console
 shows an error. the patch fixes these issues and the preview matches what
 I see on the front end.
 >
 > Replying to [comment:18 DH-Shredder]:
 > > From Mika:
 > >
 > > When a gallery has image attachment, but no thumbnail file present, or
 if the base photo is smaller than the thumbnail size, the gallery throws
 errors in the console and fails silently, not showing the placeholder-
 gallery at all.
 > >
 > > For no thumbnails:
 > >
 > > {{{
 > > Uncaught TypeError: Cannot read property 'url' of undefined
 > > }}}
 > >
 > > For smaller than thumbnails:
 > > {{{
 > > TypeError: attachment.sizes.thumbnail is undefined
 > > }}}
 > >
 > > http://wordpress.org/support/topic/39-beta-1-gallery-preview-in-
 editor-not-working-with-small-images?replies=2
 > > http://wordpress.org/support/topic/39-beta-1-un-thumbed-images-block-
 gallery?replies=4

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26959#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform