[wp-trac] [WordPress Trac] #26979: Hook Docs (6): wp-includes/revision.php

[WordPress Trac]

#26979: Hook Docs (6): wp-includes/revision.php
------------------------------------+------------------------------
 Reporter:  adamsilverstein         |       Owner:  DrewAPicture
     Type:  defect (bug)            |      Status:  reviewing
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Revisions               |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  docs
------------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:  needs-patch => has-patch dev-feedback


Comment:

 Thanks for the review and feedback; I have (hopefully) addressed all these
 issues in [attachment:26979.2.diff].


 Replying to [comment:5 DrewAPicture]:
 > Here are some notes on [attachment:26979.diff]:
 >
 > `_wp_post_revision_fields` filter:
 > * Don't need the hash notation here since it's really just an array of
 translatable strings. You can just say:
 > `@param array $fields List of fields to revision. Contains 'post_title',
 'post_content', and 'post_excerpt' by default.`
 > * Should only be one space between the `@since` tag and version
 >
 > `wp_save_post_revision_check_for_changes` filter:
 > * Need a docs-specific variable for the first parameter. Maybe
 `$changes`.
 > * s/id/ID in two places
 >
 > With the above changes should be able to get this in shortly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26979#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform