[wp-trac] [WordPress Trac] #24859: Media Library does not have a loading indicator

WordPress Trac noreply at wordpress.org
Mon Mar 10 15:57:59 UTC 2014


#24859: Media Library does not have a loading indicator
------------------------------+-----------------------------
 Reporter:  jeffr0            |       Owner:  wonderboymusic
     Type:  task (blessed)    |      Status:  reopened
 Priority:  normal            |   Milestone:  3.9
Component:  Media             |     Version:  3.5
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  javascript
------------------------------+-----------------------------

Comment (by kadamwhite):

 I haven't tested [attachment:24859.13.diff] locally, but it doesn't look
 like this would work -- we're only setting a timeout when we check `if ( !
 this.spinnerTimeout ) { `, but we're never setting that property back to
 undef or 0. Wouldn't that make this only run the first time for each
 spinner? I'd assume we'd need to do something like `this.spinnerTimeout =
 clearTimeout( this.spinnerTimeout );` (which would set it back to
 `undefined`).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24859#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list