[wp-trac] [WordPress Trac] #27111: Turning off global comments should include existing content
WordPress Trac
noreply at wordpress.org
Sun Mar 9 23:01:56 UTC 2014
#27111: Turning off global comments should include existing content
-------------------------+-----------------------------
Reporter: jenmylo | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Comments | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: administration
-------------------------+-----------------------------
Comment (by jackreichert):
Replying to [comment:14 nacin]:
> * You want to disable comments by default for all current posts, too.
How can we do that without forcibly updating all of them to be 'closed'?
Store a timestamp in the option. If the post date is earlier than that
timestamp, then it's 'closed'.
>
> * What if you then want to go back and set one of those posts to
'open'? This, I am not sure about. This is where forcibly updating the DB
would have been easier, as there's no transient state then. We would need
to come up with a new status 'override-open' which forces it to be open,
even though a filter has dictated it to be closed.
It the patch I submitted above (#comment:3), instead of changing the
functionality of `close_comments_for_old_post`, I added an extra option to
the options table: `global_comment_status`. This way you can close off all
comments but it wouldn't effect the specific comment's status.
That solves two problems:
1) Changing the functionality of something that people are expecting to
something else.
2) Allowing an undo option.
Just a thought.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27111#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list