[wp-trac] [WordPress Trac] #27327: Twenty Fourteen: jquery on toggle search has alert (was: Twenty Fourteen - jquery on toggle search has alert)

[WordPress Trac]

#27327: Twenty Fourteen: jquery on toggle search has alert
---------------------------+------------------------------
 Reporter:  blondishnet    |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:  javascript
---------------------------+------------------------------
Changes (by SergeyBiryukov):

 * component:  Themes => Bundled Theme


Old description:

> While inspired to use the same drop down toggle search feature as Twenty
> Fourteen, I was inspecting the code from between line 57 and line 69 of
> functions.js.
>
> This is the alert that came up.
>
> event.returnValue is deprecated. Please use the standard
> event.preventDefault() instead.
>
> I ended up doing my own type of work around with this -
>
> Whether you use that or some or none... no worries. Just wanted to let
> you know about the alert
>

> {{{
> jQuery(document).ready(function($){
>         $('#toggle-search').on('click', function(e){
>                 e.preventDefault();
>                 $('#search-container').slideToggle();
>         })
> });
> }}}

New description:

 While inspired to use the same drop down toggle search feature as Twenty
 Fourteen, I was inspecting the code from between line 57 and line 69 of
 functions.js.

 This is the alert that came up.
 {{{
 event.returnValue is deprecated. Please use the standard
 event.preventDefault() instead.
 }}}
 I ended up doing my own type of work around with this -

 Whether you use that or some or none... no worries. Just wanted to let you
 know about the alert


 {{{
 jQuery(document).ready(function($){
         $('#toggle-search').on('click', function(e){
                 e.preventDefault();
                 $('#search-container').slideToggle();
         })
 });
 }}}

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27327#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform