[wp-trac] [WordPress Trac] #27317: Update wp_insert_user function to return 'pre_user_login' filter WP_Errors

[WordPress Trac]

#27317: Update wp_insert_user function to return 'pre_user_login' filter WP_Errors
------------------------------------+-----------------------------
 Reporter:  crazycoolcam            |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Users                   |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------------
Changes (by danielbachhuber):

 * keywords:  needs-unit-tests => has-patch dev-feedback


Comment:

 Using `validate_username()` and `username_exists()` as corollaries,
 27317.4.diff applies the `illegal_user_logins` filter in a few more places
 and adds unit tests.

 My concern is now that this code isn't very DRY. In diving into this, it
 appears our user login validation code isn't very DRY either. I don't
 think this filter is an easy win now — needs more consideration.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27317#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform