[wp-trac] [WordPress Trac] #27003: Introduce wp_get_network() and begin cleanup of multisite load
WordPress Trac
noreply at wordpress.org
Thu Mar 6 06:15:53 UTC 2014
#27003: Introduce wp_get_network() and begin cleanup of multisite load
----------------------------+------------------------
Reporter: jeremyfelt | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.9
Component: Bootstrap/Load | Version: trunk
Severity: normal | Resolution:
Keywords: needs-testing | Focuses: multisite
----------------------------+------------------------
Comment (by jeremyfelt):
Some thoughts.
* Should a requested path be considered case sensitive for finding
site/network? #26403 has a `strtolower()` patch.
* Some sort of `site_not_found` hook (see #21143) can be useful as a
redirect opportunity.
* Some sort of hook in `ms_not_installed()` may also be useful. This is
less of a redirect opportunity and more of an "oh, crap. now what."
opportunity.
* `ms_not_installed()` docs are misleading. We mostly call on it when a
network cannot be found, but the errors seem centered around missing
sites. The errors are also (purposely?) vague. We could probably be a bit
more explicit about what has happened when `is_admin()`. This is probably
worth a new ticket for 4.0.
* I think the current cookie domain stuff works for current
configurations. Everything can already be (and is being) overridden in
sunrise. It is worth looking at in 4.0 to try and support more arbitrary
domains and paths.
[https://core.trac.wordpress.org/attachment/ticket/27003/27003.22.diff
27003.22.diff] moves the site/network not found block up a bit and joins
it with the empty `$current_site` check. This can all happen before the
cookie domain is set and before we try to find a network's main site.
The main goal for this patch is to add documentation to some of the
redirect behavior and to identify where we can hook in for customization.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27003#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list