[wp-trac] [WordPress Trac] #24859: Media Library does not have a loading indicator
WordPress Trac
noreply at wordpress.org
Wed Mar 5 17:09:55 UTC 2014
#24859: Media Library does not have a loading indicator
-------------------------------------+-------------------------
Reporter: jeffr0 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.9
Component: Media | Version: 3.5
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses: javascript
-------------------------------------+-------------------------
Comment (by kovshenin):
Looking at .2.diff. I like the general idea of ajax:start and ajax:end,
however, the spinner count incr/decr has been moved away from
updateSpinner and the check for spinnerActions. So in theory:
* ajax:start could increment the spinner count for query-attachments,
spinner shown, count 1
* ajax:start increments the spinner count for an action called foo-bar,
spinner shown, count 2
* ajax:end for query-attachments, spinner still shown, count back to 1
* ajax:end for foo-bar, count is 0, but the spinner is still shown because
updateSpinner will bail for foo-bar
In reality though, I haven't found a neat way to reproduce this, but I
think either way we should keep the action check closer to the spinner
count.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/24859#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list