[wp-trac] [WordPress Trac] #27278: More sanity to add_theme_support( 'html5' )

[WordPress Trac]

#27278: More sanity to add_theme_support( 'html5' )
-------------------------+------------------------------
 Reporter:  jond3r       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Themes       |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------

Comment (by SergeyBiryukov):

 > Though discouraged (ticket:26697#comment:12), it is currently possible
 and legitimate to use:
 > {{{ add_theme_support( 'html5' ); }}}
 > which adds support for the three types 'comment-list', 'comment-form'
 and 'search-form', but not the new type 'gallery'! Thus, as the code
 stands today 'gallery' is treated as a second-class citizen, which it does
 not deserve!

 That list is just for backwards compatibility, new items should not be
 added there.

 [attachment:27278.4.diff] adds a `_doing_it_wrong()` call and a "Back
 compat" comment, per comment:12:ticket:26697. I think that's all we need
 here. We didn't do that originally, as the consensus in
 comment:12:ticket:24932 was that `_doing_it_wrong()` was not necessary
 until we actually had a new markup in some other function. Now that we've
 added it to `gallery_shortcode()`, let's do this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27278#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform