[wp-trac] [WordPress Trac] #26879: Hello, new users. Here is an Error.

[WordPress Trac]

#26879: Hello, new users. Here is an Error.
-------------------------------------------------+-------------------------
 Reporter:  mrtortai                             |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  3.9
Component:  Upgrade/Install                      |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion docs-feedback  |     Focuses:
  needs-testing                                  |
-------------------------------------------------+-------------------------

Comment (by mrtortai):

 Hello,

 Thank you. I appreciate the feedback.

 26879-8.patch is attached which is tested against
 http://develop.svn.wordpress.org/trunk/src in order to make use of the
 latest changes from #12506

 > I believe the whitespace illustrated on the left side of "WordPress
 Login.jpg" is intentional.
 > 24px all around is pretty constricting. Let's push independent changes
 into new tickets and keep
 > the focus on the proposal here.

 I'd like to see this change (the login form on the left side of "WordPress
 Login.jpg" appears odd to my eyes), but I agreed that this should not be
 included within the ticket. 26879-8.patch has removed the change to the
 login form.

 A few notes related to the
 [http://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2014-03-05&sort=asc#m804296 2014-03-05 IRC chat]

 > Mar 05 03:05:37 +0000 2014 helen
 > background: aliceblue?
 > Mar 05 03:06:53 +0000 2014 nacin
 > I *think* the goal was to make the non-editable wp-config.php look
 neither writable nor disabled?

 Correct. That was partly the reason, the other reason was to put a slight
 focus on the wp-config.php file contents.

 > Mar 05 03:18:01 +0000 2014 nacin
 > the way the logo was implemented is a bit weird
 > Mar 05 03:21:58 +0000 2014 nacin
 > the logo also lost top padding when compared to readme.html
 > Mar 05 03:22:43 +0000 2014 nacin
 > oh, funny
 > Mar 05 03:22:49 +0000 2014 nacin
 > the logo implementation is copied from install.css

 Yup. :-)

 Without the patch, the position of the white body in first install page,
 setup-config.php and error pages are completely different. This patch
 ensures that the position of the white body and the logo is consistent
 throughout the install process. The white body and logo placement in
 readme.html is slightly off only due to the presence of the scrollbar on
 the long page. #wontfix
 However, it could be fixed by adding this to setup-config.php: body
 {overflow-y: scroll}

 Most of the new CSS I added was simply to correct various little
 inconsistencies.
 For example, body {} in install.css Line 6 includes -webkit-font-
 smoothing: subpixel-antialiased;
 But body {} in the setup-config.php pages (wp-includes/functions.php Line
 2194) did not.

 Mar 05 03:12:16 +0000 2014 helen
 i like where it's going though
 Mar 05 03:15:02 +0000 2014 nacin
 me too
 Mar 05 03:16:03 +0000 2014 DH-Shredder
 I'm a fan as well. A user's first experience being "It's broke," is less
 than ideal.

 Thanks :-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26879#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform