[wp-trac] [WordPress Trac] #27016: Make placeholders/MCE views for Audio/Video shortcodes
WordPress Trac
noreply at wordpress.org
Sun Mar 2 06:08:11 UTC 2014
#27016: Make placeholders/MCE views for Audio/Video shortcodes
----------------------------+-------------------------
Reporter: wonderboymusic | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.9
Component: Media | Version: 3.6
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
----------------------------+-------------------------
Comment (by gcorne):
The functionality looks to be a good addition, although it would be nice
if the modal also included a player above the various settings in the
details view so that the user could preview the audio or video file.
In terms of the code, as I tried to illustrate in
[attachment:26631.15.patch:ticket:26631 26631.15.patch], I am not super
fond of having a function that generates constructors. I think it is
better for the particular instance to take options that change the
behavior of the instance or to declare separate constructors and use
either composition, mixins, or inheritance (ordered in terms of
preference) to keep things DRY.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27016#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list