[wp-trac] [WordPress Trac] #6698: Editing a published post causes excessive pings / closing comments on old posts causes trackbacks
WordPress Trac
noreply at wordpress.org
Sat Mar 1 05:55:02 UTC 2014
#6698: Editing a published post causes excessive pings / closing comments on old
posts causes trackbacks
------------------------------+-----------------------------
Reporter: lapcat | Owner:
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: Future Release
Component: Pings/Trackbacks | Version: 2.8.1
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
------------------------------+-----------------------------
Comment (by jeremyfelt):
Only pinging when a post has truly been modified makes sense, but proves
difficult.
I started going down the road of removing the default `publish_post` hook
to `_publish_post_hook()` if post content was different. That alone
disables `xmlrpc_publish_post`, which may still be desirable. We could
instead move the scheduling of the event to `wp_insert_post()` to get
around that.
However... where do we draw the line for a post being updated? Comparing
various `WP_Post` properties is pretty easy, but there can be a variety of
post meta attached that may or may not indicate a valid change. Even an
administrative task like closing comments could be considered helpful in
notifying others that comments are no longer accepted on a piece of
content.
After poking around, I'm starting to think that the current content based
behavior makes sense - always ping. If there is something specific that
should be avoided, a hook on `transition_post_status` can remove the
default action before it fires.
I'm not entirely sure that we should consider this a 'bug'. It may make
sense to close as maybelater to reconsider if demand mounts in the future.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/6698#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list