[wp-trac] [WordPress Trac] #27884: Unit testing Multisite's bootstrap

[WordPress Trac]

#27884: Unit testing Multisite's bootstrap
----------------------------+------------------------
 Reporter:  jeremyfelt      |       Owner:  nacin
     Type:  enhancement     |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  Bootstrap/Load  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  multisite
----------------------------+------------------------
Changes (by jeremyfelt):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 As @danielbachhuber mentioned, moving the `require()` statements out of
 ms-settings.php and wp-settings.php caused a break with WP-CLI, which
 closely mirrors the load process here. If the same change was made in WP-
 CLI, this would break back-compat.

 It appears that we can instead use `require_once()` for ms-load and ms-
 default-constants and leave this in ms-settings.php without causing issue.

 [https://core.trac.wordpress.org/attachment/ticket/27884/27884.3.diff
 27884.3.diff] makes this change. It's likely worth reverting [28910] for
 the time being to make sure this is the right move.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27884#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform