[wp-trac] [WordPress Trac] #20496: Previews should redirect to the permalink if the post has been published

[WordPress Trac]

#20496: Previews should redirect to the permalink if the post has been published
------------------------------+-----------------------------
 Reporter:  evansolomon       |       Owner:  wonderboymusic
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  4.0
Component:  Canonical         |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 [28874] broke four unit tests:
 {{{
 There were 4 failures:

 1) Tests_Canonical::test with data set #10 ('/?category_name=cat-a,cat-b',
 array('/?category_name=cat-a,cat-b', array('cat-a,cat-b')))
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'/?category_name=cat-a,cat-b'
 +'/?category_name=cat-a%2Ccat-b'

 S:\home\wordpress\develop\tests\phpunit\tests\canonical.php:133
 S:\usr\local\php5\phpunit:46

 2) Tests_Canonical_HTTPS::test with data set #10
 ('/?category_name=cat-a,cat-b', array('/?category_name=cat-a,cat-b',
 array('cat-a,cat-b')))
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'/?category_name=cat-a,cat-b'
 +'/?category_name=cat-a%2Ccat-b'

 S:\home\wordpress\develop\tests\phpunit\tests\canonical.php:133
 S:\usr\local\php5\phpunit:46

 3) Tests_Canonical_NoRewrite::test with data set #3 ('/?p=358 ',
 array('/?p=358', array('358')))
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'/?p=358'
 +'/?p=358+'

 S:\home\wordpress\develop\tests\phpunit\tests\canonical.php:133
 S:\usr\local\php5\phpunit:46

 4) Tests_Canonical_NoRewrite::test with data set #4 ('/?p=358%20',
 array('/?p=358', array('358')))
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'/?p=358'
 +'/?p=358+'

 S:\home\wordpress\develop\tests\phpunit\tests\canonical.php:133
 S:\usr\local\php5\phpunit:46
 }}}

 Caused by `remove_query_arg()`. The first two seem minor, but the other
 two look like an issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20496#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform