[wp-trac] [WordPress Trac] #28678: Document default attributes for wp_playlist_shortcode()
WordPress Trac
noreply at wordpress.org
Sun Jun 29 21:06:08 UTC 2014
#28678: Document default attributes for wp_playlist_shortcode()
----------------------------------------+------------------------------
Reporter: DrewAPicture | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Media | Version:
Severity: normal | Resolution:
Keywords: good-first-bug needs-patch | Focuses: docs
----------------------------------------+------------------------------
Changes (by DrewAPicture):
* keywords: good-first-bug has-patch => good-first-bug needs-patch
Comment:
Thanks for the patch. This is a really great start, nice work.
Just a few nits:
* Looks like a couple of parameters are missing defaults at the end of the
description
* For the `$order` and `$orderby` parameters, we should check whether the
'asc'/'desc' values are case sensitive. In most other places in core
they're full-caps, for instance.
* In the `$images` parameter, the parenthesis example should be inside the
period of the first sentence instead of on its own.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28678#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list