[wp-trac] [WordPress Trac] #28639: WP_Embed::cache_oembed() only works for posts and pages by default

[WordPress Trac]

#28639: WP_Embed::cache_oembed() only works for posts and pages by default
-------------------------------------------------+-------------------------
 Reporter:  helen                                |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Embeds                               |  Review
 Severity:  normal                               |     Version:
 Keywords:  reporter-feedback has-patch dev-     |  Resolution:
  feedback                                       |     Focuses:
-------------------------------------------------+-------------------------
Changes (by bordoni):

 * keywords:   => reporter-feedback has-patch dev-feedback


Comment:

 Replying to [comment:1 helen]:
 There is 2 ways of doing it:

 1. As you said explicitly excluding the `revision` post type from the
 caching
 2. Unsetting `revision` by applying a filter to the
 `embed_cache_oembed_types` by default

 Personally I like the second one better because if someone wants to do
 caching for revisions for some weird reason it could be done.

 Anyways both of the possibilities diff are attached.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28639#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform