[wp-trac] [WordPress Trac] #23318: Plugins Admin Showing Details for Wrong Plugin

[WordPress Trac]

#23318: Plugins Admin Showing Details for Wrong Plugin
-------------------------+----------------------------
 Reporter:  miqrogroove  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  WordPress.org
Component:  Plugins      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  2nd-opinion  |     Focuses:
-------------------------+----------------------------

Comment (by DavidAnderson):

 Replying to [comment:7 jdgrimes]:
 > The reason I proposed this second header (actually, @rmccue did) is
 because WP has difficulty determining the exact ID of a plugin (that is
 the main brunt of this ticket, and #13928). The `Update Service:` header
 wouldn't actually fix this issue.

 It does fix it, if the "Update Service" header can have a separator. e.g.
 "Update Service: acmecorp/superplugin". i.e. Both functions can be handled
 with a single header. Whatever theoretical 3rd party plugin provides the
 "acmecorp" update service will know how to parse anything after the
 separator too.

 I'm not yet seeing, though, why WP needs to know the exact ID of a plugin
 as distinct from its slug. If the plugin is from the wordpress.org
 repository, then WP identifies it through the slug... if the slug has been
 changed, then updating it with a pristine version (i.e. unchanged slug) is
 probably a terrible idea.... on the other hand, if the slug is *not* from
 the wordpress.org repository, then it's in 3rd party territory anyway and
 the developer can implement whatever mechanism he pleases for identifying
 the plugin (i.e. it's not a problem that core needs to solve).

 I think I'm really saying that 1) I agree with crazycoders in #4 - the
 slug is the identifier, and if you decided to change/break it, then you
 should have no expectation that anything else will work any more than if
 you decide to replace "<?php" with "<?squirrels!" everywhere. 2) I think
 it's best just to focus on the "plugin info fetched from the wrong remote
 service" problem.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23318#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform