[wp-trac] [WordPress Trac] #28619: Add more filters to tune audio and video shortcode library

WordPress Trac noreply at wordpress.org
Thu Jun 26 21:52:22 UTC 2014

#28619: Add more filters to tune audio and video shortcode library
 Reporter:  Fab1en       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Media        |     Version:  3.9.1
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:

Comment (by DrewAPicture):

 Replying to [comment:2 Fab1en]:
 > OK, sorry. I thought we would discuss this a bit before adding docs.
 > Inline docs added for filters in [attachment:28619.2.patch]

 Hi @Fab1en, thanks for the patch. In many cases docs do get added at the
 end of the development cycle for new hooks, though in this case I think
 they really serve to help explain what's being proposed. :)

 Your hook docs actually look pretty great. Probably the only things I
 would change would be the short descriptions. Our suggested language for
 filters is "Filter X" or "Filters X". So in this case, rather than using,
 "Adds HTML before the X", maybe it would be better as something like
 "Filter HTML prepended to the audio shortcode output." or similar. Make

 Also, if you pass the `--no-prefix` flag when generating your patches, it
 won't attach all of your personal information at the top of the patch :-).

Ticket URL: <https://core.trac.wordpress.org/ticket/28619#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list